Louis Pilfold

Results 761 comments of Louis Pilfold

Thank you > What is the current approach used to test this feature? Are there snapshots for it? Yup, in with the JS tests there is a TS snapshot macro

Thank you! This would be a really nice improvement. It's not super clear to me how we would implement this presently. Let's make sure we have a design before work...

> Is find_node used for important stuff or can it be changed to please the LSP UX? It's only used by LSP and is safe to change. The LSP is...

Had an attempt here https://github.com/gleam-lang/gleam/commit/eebdbec5784cd82a46296e90765ca664bf7eb5af Let's see how it does tonight

I think having an additional field on the error sounds good as it'll be otherwise be the same.

Maybe, though I worry that there's not a universal binary format for bools. How should they be encoded?