Neo4j-PHP-OGM icon indicating copy to clipboard operation
Neo4j-PHP-OGM copied to clipboard

Published 20 hours ago • verified publisher icon lphuberdeau

Repositiory now implements Doctrine\Common\Persistence\ObjectRepository

Open Deltachaos opened this issue 10 years ago • 3 comments

Because all Repositiories should implement this interface

Deltachaos avatar May 21 '14 12:05 Deltachaos

@Deltachaos I'm currently managing to implement the Doctrine Common interfaces (especially ObjectManager and ObjectRepository) correctly. This is definitively a need, but I don't see the benefit of implementing interfaces and throwing exceptions if they are used as originally intended by Doctrine Common.

frne avatar May 23 '14 12:05 frne

If it can be supported, we should support the arguments, not just accept them to respect the interface. That would be breaking the contract.

If the argument cannot be implemented for technical reasons, then I agree on an exception to avoid false promises.

lphuberdeau avatar May 28 '14 19:05 lphuberdeau

@lphuberdeau Working on a solution based on #74 which also implements the ObjectManager interface. Will propose, once it's final ;)

BTW. Thx 4 merge...

frne avatar May 28 '14 19:05 frne