Luc Patiny

Results 204 comments of Luc Patiny

There are 2 different issues. One is if we load the FT data and then try to autophase it. The result is not correct at all (a correction of 155...

@nes0zx How was this data generated. It seems there is an issue with the processed data that we preferably load. The width is not correct. Looking at procs file we...

Yes sure. It is just to reduce the memory impact (and therefore garbage collector)

I'm using https://github.com/mljs/spectra-processing/blob/master/src/matrix/matrixZRescale.ts to rescale the values between 0 and 255. I didn't think about contaminating image-js with this method and that the rescale should be done before.

![image](https://user-images.githubusercontent.com/1484241/227785108-66518c67-e3c0-47b8-a580-95ae6db1db67.png) Some external links: - https://stackoverflow.com/questions/22656698/perspective-correction-in-opencv-using-python - https://pyimagesearch.com/2014/09/01/build-kick-ass-mobile-document-scanner-just-5-minutes/ - https://pyimagesearch.com/2014/08/25/4-point-opencv-getperspective-transform-example/

Is there a specific reason that we didn't return the image kind in getRawImage ? https://github.com/image-js/image-js-typescript/blob/d3f0d998c623259c71d795e0abb9d6925fca89ba/src/Image.ts#L466-L472 The idea was actually also to return the kind so that we can always...

Not super convincing indeed but I don't think we should spend more time on this for now.

This method will only apply on a binary image (mask) and return a new mask. ``` const skeleton = mask.skeletonize(); ``` Need to check what is the best algorithm and...

Optimisation with the current algorithm will not be easy to achieve even for RGB8 because for each pixel we calculated variables with crossed values: https://github.com/image-js/image-js-typescript/blob/24a123720f45e8a8219f995d23e4e70165d8f54a/src/correctColor/correctColor.ts#L83-L106 This means that if we...

@opatiny I think the current algorithm is based on a publication. Could you add a DOI link in the code. https://github.com/image-js/image-js-typescript/blob/24a123720f45e8a8219f995d23e4e70165d8f54a/src/correctColor/correctColor.ts#L11-L12