cmockery2 icon indicating copy to clipboard operation
cmockery2 copied to clipboard

Add checks for whether a string is in another string

Open tjk opened this issue 9 years ago • 3 comments

Hey there!

I'll squash and rebase after some feedback.

  1. could you please let me know if you are interested in this feature?
  2. am I missing something when it comes to the current state of the .gitignore?
  3. I put this patch together quickly and could have missed something obvious...
  4. I'll be testing this shortly, but wanted to just get this up ASAP.
  5. my vim config automatically changes some whitespace -- let me know if you want me to do undo those changes, please.
  6. I just noticed in the other PR there are unit tests somewhere... didn't notice them in quick glance + should I update example directory?

Thanks for any comments!

tjk avatar Jul 10 '15 20:07 tjk

Hi @tjk , I'll make some time this week to review it. Thank you for the patch.

lpabon avatar Jul 19 '15 16:07 lpabon

@tjk Sorry, it has taken me so long to review this. I just finished my latest project Heketi. I'm reviewing now

lpabon avatar Oct 14 '15 20:10 lpabon

@tjk Just reviewed your code. I really, really like this. Please let me know if you have time to add unit tests since it has been a while.

lpabon avatar Oct 14 '15 20:10 lpabon