flow2schema icon indicating copy to clipboard operation
flow2schema copied to clipboard

Allow recursive types, BooleanLiteralTypeAnnotations and do not crash on function types

Open vitalif opened this issue 5 years ago • 3 comments

Hi! Awesome module, thanks! The only problems I've encountered are:

  • lack of BooleanLiteralTypeAnnotation support
  • lack of support for recursive types
  • crash (assert with null) on function types

I attempted to fix these problems, please see the PR. It probably doesn't fix the recursive type problem for parametrized types, but at least it does so for simple ones.

vitalif avatar May 23 '19 21:05 vitalif

It seems I've broken a lot :( Can you give me a hint about how to fix the recursive type issue better?

vitalif avatar May 23 '19 21:05 vitalif

Ok I've pushed new version, it still fails a lot of tests but changes are intended this time :)

vitalif avatar May 23 '19 21:05 vitalif

@vitalif I just used your support for recursive types, super helpful, would love to see this merged.

@loyd This project has been working surprisingly well for my use case, but understandably it hasn't seen much maintenance for a while. Would you be interested in any help maintaining it?

lyleunderwood avatar Dec 20 '19 19:12 lyleunderwood