clickhouse.rs icon indicating copy to clipboard operation
clickhouse.rs copied to clipboard

Published 20 hours ago • verified publisher icon loyd

Added HTTPS support

Open wootmatt opened this issue 2 years ago • 1 comments

Hey guys, love the client.

Brief summary of changes:

  • Added hyper-tls
  • Added a function to create clients over HTTPS called Client::new_secure.

wootmatt avatar May 04 '22 18:05 wootmatt

Hello, thanks for the PR!

I think, the client should seamlessly detect the https scheme instead of using the dedicated constructor, which will allow changing the mode via configuration without changes in code. Fortunately, hyper-tls support both, https and http schemes.

Secondly, I prefer to move such functionality under the tls feature. It should be enabled by default.

Thus, I would like to alter the Default instance and use hyper-tls if the tls feature is enabled.

Would you like to improve the implementation? Alternatively, you can create an issue.

loyd avatar May 15 '22 01:05 loyd

Closed in favor of https://github.com/loyd/clickhouse.rs/pull/54

loyd avatar Jan 03 '23 07:01 loyd