Lachlan Donald
Lachlan Donald
I reckon it’s going to get too complicated to do with flags @toolmamtim. I’m still also a bit unsure about whether requiring everyone use digests should be a thing, but...
Personally I really liked @toolmantim's use of the `@` like docker uses. I like at least using `sha1` as it allows us to move to other hash formats over time....
IMO this would be just as legit (excluding the branch/tag/version) in favor of the content addressable version. `docker@git-sha1:f199bc812a7d7c770139fe8f67203010e103d0f8`
Some context on how Docker does it: https://engineering.remind.com/docker-image-digests/ I like `docker@sha1:f199bc812a7d7c770139fe8f67203010e103d0f8`
Another approach to this might be to actually split out the phases as different structs in different files. 🤔
We'll investigate!
For now the conclusion in discussion with @keithpitt is that we should encourage people to use tags vs branches!
Good question @mipearson! That was why we didn't implement it this way initially.
Yeah, most likely. Will experiment. In terms of the s3 secrets plugin, I just think that s3 is not a good spot for secrets. It's very hard to make efficient....
Thanks @pda, this is interesting. One thing I'd considered before is allowing pipeline mutations as part of pipeline, e.g `buildkite-agent pipeline upload --default-timeout-in-minutes 10`, possibly also `--enforce-timeout-in-minutes 10`. Beyond the...