opentitan

opentitan copied to clipboard

[cryptotest] Add parser for manual hjson ECDSA tests

1

Adds a parser to incorporate the manual hjson ECDSA `verify` tests in `/sw/device/tests/crypto/testvectors/ecdsa_p256_verify_hardcoded.hjson` into the existing cryptotest framework. I verified the tests pass when applied on top of #20853 with...

RyanTorok

This fixes issue #21517. The first two three commits have no functional change, but make the code a bit easier to read. Following that is a change to the frontdoor...

rswarbrick

[spi_device] Late CSb de-assertion for op-complete commands

7

The current SPI_DEVICE HWIP has a few limitation of detecting the host system's misbehaviors: - If host de-asserts CSb prior to the full 8 bit opcode, HW IP silently drops...

eunchan

[spi_device] Add an event for unexpected host behavior

8

## Host jumps the read address The SPI_DEVICE assumes the host reads the address relatively sequentially. If not, (read next 1kB then roll back to previous 1kB), it is worth...

eunchan

[spi_device] Remove filter CSR

4

As passthrough logic filters incoming commands if they are not in the command information entries, filtering CSR usage is low. We could introduce the `filter` field in the CMD_INFO structure...

eunchan

[topgen] Remove duplicated license headers from autogen files

5

A couple of our auto-generated files have duplicated license headers. One copy is inserted by `util/topgen.py` and the other copy comes in via template file. In addition some auto-generated files...

vogelpi

[spi_device] Tagging for Upload Command/Address FIFOs and Payload Buffer

9

Currently, address fifo and the payload do not have any information that SW is able to figure out which command these address and/or payload belong to. If the host system...

eunchan

[spi_device] Read Status, Read JEDEC ID, Read SFDP to have fixed value (read-only) in CMD_INFO

4

As same as `EN4B` / `EX4B` , Read Status (1,2,3) , Read JEDEC ID, Read SFDP commands have fixe values in their command information entries. It is better to split...

eunchan

[spi_device,rtl] Address TODO concerning pull-ups at the end of transaction in TPM_MODE

1

### Description https://github.com/lowRISC/opentitan/blob/99f0afda05ed383d4be65c52d5ba3e80338ceea3/hw/ip/spi_device/rtl/spi_tpm.sv#L1124-L1131 May be related to glitch behaviour / recovery - https://github.com/lowRISC/opentitan/issues/15721 - https://github.com/lowRISC/opentitan/issues/15517

hcallahan-lowrisc

[spi_device,rtl] Handle SRAM integrity error output decisively

3

### Description https://github.com/lowRISC/opentitan/blob/39f9a9e57286f0d2a72c624bb19b9bd3a4c3bdf0/hw/ip/spi_device/rtl/spid_readsram.sv#L344-L347 e.g. 1) Update comment to explain decision to leave unconnected 2) Create an alert from this signal 3) ...

hcallahan-lowrisc