[dv,tcp_server] avoid conn-related assertion
Treat more errors from read/send as non-fatal, just closing the connection and allowing a new client to attach. It's preferable to avoid assertions for runtime conditions that are potentially recoverable.
@luismarques Potentially someone from the SW team has related expertise and could review this?
What error code are you observing? ECONNRESET? I'd prefer to add relevant error codes instead of silently treating all error codes as network issues.
Also -- read with 0 bytes returned means graceful disconnection from other side -- we should probably treat as such. (although this is an issue with existing code)
What error code are you observing? ECONNRESET? I'd prefer to add relevant error codes instead of silently treating all error codes as network issues.
Also -- read with 0 bytes returned means graceful disconnection from other side -- we should probably treat as such. (although this is an issue with existing code)
Yes, one case was definitely ECONNRESET. I can add the 0 return value handling. I guess I still wonder which other possible errno values from read and send would warrant an assertion that blows up our emulation model, which is a shared and long-running resource.