opentitan
opentitan copied to clipboard
lowRISC
Uart status interrupts
This includes a commit from https://github.com/lowRISC/opentitan/pull/21226 which is a cip_lib change required for all status type interrupts. So need to ensure one of the PRs gets rebased if the other has gone in.
Thanks @GregAC - maybe it makes sense to split out the CIP fixes into a separate PR since those will benefit others as well. I believe we need to introduce a similar masking in the generated "all interrupts" TLT. Sorry that I did not get to this yet, will try to look into it on Monday.
CC @andreaskurth @vogelpi @alees24
maybe it makes sense to split out the CIP fixes into a separate PR since those will benefit others as well. I believe we need to introduce a similar masking in the generated "all interrupts" TLT. Sorry that I did not get to this yet, will try to look into it on Monday.
Yes, maybe worth splitting all commits that apply to more IPs than only flash_ctrl into a separate PR, so that those become available asap while the failing tests in https://github.com/lowRISC/opentitan/pull/21226 get resolved?
Latest push addresses CI failures, will address the splitting out/merging with other work of the CIP changes separately.
This PR should not be merged until the CIP change work is addressed.
I've spun out the first commit, which is a CIP fix that is useful for status interrupt in general to another PR: https://github.com/lowRISC/opentitan/pull/21804
As there's some CI issues with the CW310 tests that may take a little longer to solve it'd be good to get the CIP fix in sooner.
Thanks to @jwnrt for the pointers so I could debug and (hopefully) fix the final CI issues.
I'll also do a PR to switch TX empty to a status type interrupt as requested in https://github.com/lowRISC/opentitan/issues/16693 but I'll do that in a separate PR
@timothytrippel could you check out the OTTF change? (Final commit)
OTTF changes LGTM.
