opentitan icon indicating copy to clipboard operation
opentitan copied to clipboard

[RV_DM]rv_dm_abstractcmd_status_vseq

Open BasitMehmood opened this issue 1 year ago • 4 comments

This is one of new test sequences that present to OT team. It covers both paths as suggested(DM+dm_mem).

BasitMehmood avatar Feb 15 '24 11:02 BasitMehmood

This isn't quite ready to land yet.

I suggest that you split it into two commits. The first commit can add a testplan entry and the second commit can implement that testpoint.

The implementation also needs some work! My best suggestion is that you alter this PR so that it just adds the testpoint. Once that's changed, file a follow-up PR that implements the test.

I have added testplan only . After that i will PR the implementation of testplan in another PR.

BasitMehmood avatar Feb 15 '24 17:02 BasitMehmood

Thanks for chopping things up. I think I've still got one question about the testplan update (https://github.com/lowRISC/opentitan/pull/21381#discussion_r1490918576), but otherwise I think it looks sensible.

rswarbrick avatar Feb 16 '24 15:02 rswarbrick

I've merged the change to the testplan (thanks). I think the head of this branch no longer contains an actual test implementation. Did you intend that to be here?

rswarbrick avatar Feb 22 '24 11:02 rswarbrick

I've merged the change to the testplan (thanks). I think the head of this branch no longer contains an actual test implementation. Did you intend that to be here?

I've merged the change to the testplan (thanks). I think the head of this branch no longer contains an actual test implementation. Did you intend that to be here?

Actually the test is implemented in another PR that you just deleted.

I've merged the change to the testplan (thanks). I think the head of this branch no longer contains an actual test implementation. Did you intend that to be here?

Actually test is implemented in another PR that you just deleted #21616. I was facing some issue in rebasing so i made a new branch.

BasitMehmood avatar Feb 22 '24 11:02 BasitMehmood