ibex icon indicating copy to clipboard operation
ibex copied to clipboard

[icache,dv] Minor tidyups after dropping PMP interface

Open rswarbrick opened this issue 4 years ago • 5 comments

Tom's RTL changes at https://github.com/lowRISC/ibex/pull/1474 simplify things dramatically on the DV side, which is nice. I made some suggested simplifications on that PR and there are probably further simplifications possible. Do them!

rswarbrick avatar Dec 10 '21 10:12 rswarbrick

Tagging @marnovandermaas to comment on whether this issue can be closed out given his understanding with ePMP work carried out recently. If unsure we can leave this issue as unresolved.

johngt avatar Jul 20 '22 13:07 johngt

@johngt As far as I can tell the simplifications are mostly done by @GregAC in: https://github.com/lowRISC/ibex/commit/72a892d62ce820d9519825e308df45c05cfbe867 The only other thing Rupert mentions is the:

need to work on this code to teach it about scrambling

I'm not sure what scrambling means in this case. Besides that I think this issue can be closed.

marnovandermaas avatar Jul 21 '22 15:07 marnovandermaas

@GregAC is it ok if I close this issue?

marnovandermaas avatar Aug 09 '22 10:08 marnovandermaas

The nits mentioned by @rswarbrick are still there so this is still live.

GregAC avatar Aug 10 '22 16:08 GregAC

The nits mentioned by @rswarbrick are still there so this is still live.

Which nits do you mean? I'm not sure what still needed beyond this commit you've already made: https://github.com/lowRISC/ibex/commit/72a892d62ce820d9519825e308df45c05cfbe867

marnovandermaas avatar Aug 12 '22 16:08 marnovandermaas