Results 74 comments of Lovesh Harchandani

@jeffprestes Thanks for pointing this, fixed [here](https://github.com/docknetwork/crypto-wasm-ts/commit/235b7f0c9b866e6c780d758b15c136f335acc445). > I believe the use case is a good one You mean MiMC one or blood group?

[The blood group test](https://github.com/docknetwork/crypto-wasm-ts/blob/master/tests/composite-proofs/msg-js-obj/r1cs/blood-group.spec.ts).

Thanks for reporting this and sorry for state of the docs. Instead of `Statement.bbsPlusSignature`, use `Statement.bbsPlusSignatureProverConstantTime` for the prover and `Statement.bbsPlusSignatureVerifierConstantTime` for the verifier. For more info, see [this](https://github.com/docknetwork/crypto-wasm-ts/blob/master/tests/scheme.ts) where...

Hi @lanterno . The PR would be very helpful and welcome. And let me know of any other questions you have as well.

@ad-Orange > One more thing... [BBS_Sharp_Short_TR.pdf](https://github.com/user-attachments/files/15905230/BBS_Sharp_Short_TR.pdf) Thanks for sharing this. The offline mode (where IdP isn't involved in creating VP) requires use of pairing friendly curve. Thus the SE needs...

@ad-Orange Thanks for the reply. > The second one is to let the user pre-provision several “blind” tokens proving that (\bar{B} = \hat{A}^sk) from the Issuer and only use them...

That's all my questions for now. Thank you for your responses. On Wed, Jul 3, 2024, 23:50 ad-Orange ***@***.***> wrote: > @lovesh > > So the user proactively creates several...

@andrea-dintino Thanks for your question and the offer to help. There are no test-vectors as of now. On each run, the tests generate random data (keys, messages, MAC).

> // Shouldn't allow sharing threshold of 1 but succeeds let (secret, shares, poly) = deal_random_secret::(&mut rng, 1, 1).unwrap(); The problem isn't the threshold but total, which shouldn't be 1....

> Expecting the comments to catch bugs is not good practice. I am not expecting the comment to catch the bug but was setting the expectation through it.