sharp-libvips icon indicating copy to clipboard operation
sharp-libvips copied to clipboard

Escape whitespace in build script

Open thetw opened this issue 4 years ago • 1 comments

I'm running into an issue when trying to use the build script on macOS. My home folder is located on a non-standard location and the drives name includes whitespace.

$ echo $PWD         
/Volumes/Storage SSD/Users/thetw/Desktop/sharp-libvips

When i try to run the build script, every command that involves the unescaped absolute path to the build folder results in errors like:

mkdir: /Volumes/Storage: Permission denied
mkdir: SSD/Users/thetw/Desktop/sharp-libvips/build: No such file or directory

As you can see the unescaped path got split at the whitespace character which obviously creates invalid paths.

Do you have a clue how we could fix that? The only way that came to my mind so far is to properly escape all occurrences of the path invocations in the build script with " or '... or do i miss something?

thetw avatar Jan 28 '21 21:01 thetw

Hi, I'd be happy to accept a PR that add quotes around filesystem paths.

As a possible workaround for now, you might be able to create a symlink without a space.

lovell avatar Jan 29 '21 07:01 lovell