ripley icon indicating copy to clipboard operation
ripley copied to clipboard

Ripley performance improvements

Open eugenepaniot opened this issue 1 year ago • 2 comments

  1. Transitioned to using https://github.com/valyala/fasthttp/ for the HTTP client;
  2. Transitioned to using github.com/valyala/fastjson/ for fast json parsing;
  3. Add custom Connection Diler to count TCP metrics (connections, bytes);
  4. Add metrics server;
  5. Add other metrics;
  6. Add handleResult listener rather create goroutine;
  7. Buffered channels;
  8. Rewrite dummyweb server on fasthttp with reuseport;
  9. Add store and print N results with the longest latency;
  10. Improve error log reporting (connection errors, http errors 5xx);
  11. Other UX improvements.

eugenepaniot avatar Mar 06 '23 19:03 eugenepaniot

@eugenepaniot I haven't been able to finish the review. Sharing my comments so far. I currently can't run the tests because:

# command-line-arguments [command-line-arguments.test]
pkg/replay.go:136:16: undefined: unsafe.String
pkg/replay.go:136:30: undefined: unsafe.SliceData

The golang 1.20 is required as these function introduced in 1.20 version.

eugenepaniot avatar Mar 21 '23 20:03 eugenepaniot

Quality Gate Failed Quality Gate failed

Failed conditions

2 Security Hotspots

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 26 '24 17:01 sonarqubecloud[bot]