love icon indicating copy to clipboard operation
love copied to clipboard

[Build Failed on RISC-V] Please consider updating autotool scripts

Open iamtwz opened this issue 2 years ago • 3 comments

Hi,

This is Jimmy from the ArchLinux RISC-V Team.

The config.guess file contained in the source code is too old to build on the latest architecture, such as RISC-V.

This can be fixed by generating new tarball by latest autotools.

Here's a patch below(in ArchLinux PKGBUILD file):

--- PKGBUILD
+++ PKGBUILD
@@ -12,6 +12,12 @@ depends=('luajit' 'freetype2' 'mpg123' 'openal' 'libvorbis' 'libmodplug' 'sdl2'

+prepare() {
+  cd $pkgname-$pkgver
+  autoupdate
+  autoreconf -fiv
+}
+

We propose a one-time fix for this via upstream, which benefits all downstream package maintainers.

Thanks.

iamtwz avatar Feb 26 '23 13:02 iamtwz

I think this is only about the generated love linux source-with-automagic-already-run downloads in our releases section, rather than our actual untouched source code, right? (config.guess is not contained in the source code in this git repository.)

In general I don't think we usually change existing older released versions of love unless something is broken with their setup on platforms we already officially support (which does not include RISC-V architectures right now).

slime73 avatar Feb 26 '23 14:02 slime73

With updated Autotools, does LOVE compiles on such RISC-V platforms? If so could you send a PR to acomodate the necessary changes?

MikuAuahDark avatar May 17 '23 12:05 MikuAuahDark

This is interesting. Sure, Love will compile on hardware with Risc-V architechture. The development is still ongoing in the newest kernels 6.6. because not all is implemented yet. Debian, Freebsd, Archlinux offichially support Risc-V. Please integrate it. It will work later.

KnorkFox avatar Nov 09 '23 11:11 KnorkFox

The next release of love (12.0) will use CMake as the primary build system on Linux instead, so I think this issue isn't applicable anymore.

slime73 avatar Mar 24 '24 23:03 slime73