love icon indicating copy to clipboard operation
love copied to clipboard

LuaSocket has released version 3.0.0

Open AegisCrusader opened this issue 2 years ago • 6 comments

https://github.com/lunarmodules/luasocket/releases/tag/v3.0.0

Do you think we should put it in Love 12.x?

AegisCrusader avatar Mar 29 '22 05:03 AegisCrusader

I'd like to know if there are any breaking changes between 3.0.0-rc1 and 3.0.0.

MikuAuahDark avatar Mar 30 '22 02:03 MikuAuahDark

One of them, I suppose, is support for Lua 5.4.3+ and more features all around. There isn't really a good changelog, though there seems to be some more flexibility with TCP options (which is what I'm mainly working with right now), especially when used with Linux.

AegisCrusader avatar Mar 30 '22 08:03 AegisCrusader

Looks like one of the breaking change is reported lunarmodules/luasocket#371

MikuAuahDark avatar Mar 31 '22 01:03 MikuAuahDark

Interesting. Yea, they'll probably need to sort that stuff out first.

AegisCrusader avatar Mar 31 '22 02:03 AegisCrusader

love is actually using a more recent version of luasocket than the 3.0rc1 tag (although it's still pretty old now): https://github.com/lunarmodules/luasocket/commit/316a945 - according to the comments of that breaking change issue, the commit which introduced the problem is older than what we use, so by updating to the tagged 3.0.0 release we won't be introducing that issue at least (since it's already there).

slime73 avatar Apr 03 '22 00:04 slime73

Another issue is reported: lunarmodules/luasocket#375

I probably have to hold the upgrade until the issues are resolved.

MikuAuahDark avatar Apr 16 '22 03:04 MikuAuahDark

Looks like LuaSocket is "stable enough" and the other issue in question has not getting any reply since, thus it's probably an invalid issue.

MikuAuahDark avatar Oct 07 '22 11:10 MikuAuahDark

Implemented via 7a85dc9df55a9b0befb3399a09d3556081b93ac7

slime73 avatar Oct 08 '22 20:10 slime73