whitebophir icon indicating copy to clipboard operation
whitebophir copied to clipboard

Make boardname case insensitive

Open DanielHabenicht opened this issue 4 years ago • 2 comments

Currently the boards are case sensitive, meaning that:

https://wbo.ophir.dev/boards/test and https://wbo.ophir.dev/boards/tesT are two different boards.

From the usability it makes sense to make those point to the same board.

Context

We are using Whiteboard with Jitsi and their room names are case insensitive. Which allows people to be in the same conference but drawing on two different boards.

I am happy to implement it, just waiting for some feedback and if there are some caveats I should be aware of?

DanielHabenicht avatar Jun 30 '21 13:06 DanielHabenicht

This is a tricky issue.

Currently, the handling in memory is case-sensitive, but there is no special handling for case-insensitive file systems.

If we implement such a feature, we should make it optional, and not activated by default. Otherwise, we would break existing wbo installations that may have different existing boards with a name that differs only in its case.

The easiest and cleanest is probably to handle this on the embedding side, when generating the WBO url from the jitsi room name.

lovasoa avatar Jun 30 '21 13:06 lovasoa

yes, indeed. I will add it there.

But might it be reasonable to add a warning here, and implement it after a while, so users can prepare for the breaking change? As for me, it does not seem to be optimal that it is case sensitive.

I can go ahead and create some logic that: Looks for an existing room:

  • if it exists does nothing (current behaviour)
    • checks if a second room with an all-lowercase name exists, if so it generates a backend warning that this will be a future breaking change.
  • if it does not exist converts the name to all lowercase
    • Creates a room with the all-lowercase name

DanielHabenicht avatar Jun 30 '21 17:06 DanielHabenicht