whitebophir icon indicating copy to clipboard operation
whitebophir copied to clipboard

environment variable WBO_MAX_BOARD_SIZE_X to give max width of board (closes #118)

Open droundy opened this issue 5 years ago • 3 comments

I just added a configuration variable MAX_BOARD_SIZE_X. I also made board.js obey the existing MAX_BOARD_SIZE (which it wasn't), and made it so you can't zoom out beyond the width of the board. The latter isn't technically necessary, and could in cases of a very wide window be annoying, but I think it's better than letting users confuse themselves with a bunch of white space that they can't write on.

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

droundy avatar Sep 24 '20 23:09 droundy

Can you have a look at the failing tests too ?

lovasoa avatar Sep 25 '20 10:09 lovasoa

It looks like the failing tests assume a given transformation matrix, which is getting broken by my code that sets the minimum zoom level.

On second thought, it seems odd that the max scaling should be reached, unless either the window is very big in the test, or the max board size is small...

droundy avatar Sep 25 '20 13:09 droundy

It looks like the cursor element (to which the transform should be applied) is not even present

lovasoa avatar Sep 25 '20 13:09 lovasoa