whitebophir icon indicating copy to clipboard operation
whitebophir copied to clipboard

Translation improvements

Open lovasoa opened this issue 5 years ago • 5 comments

The following changes were suggested by @ovari in https://github.com/lovasoa/whitebophir/pull/103#issuecomment-654673440 :

  • [ ] Instead of having one file translations.json with all the locales, we could have one file per locale?
    • This would make it easier to translate as translators can copy the en.json and create another file like hu.json.
    • It would also make it easier to see what locales are currently available as each language would have a filename.
  • [ ] Add support for multiple locales in a single language
    • Color should be Colour for en-GB
  • [ ] Make the label of the Go button on the main page (the one that allows creating a named private whiteboard) translatable
  • [ ] Keep track of the language chosen in the main page when opening a whiteboard page. However, the chosen language should not appear in the URL of the whiteboard itself, since it is what is going to be shared with other users (that may have a different preferred locale).

lovasoa avatar Jul 07 '20 08:07 lovasoa

One file per locale

Should be pretty easy to achieve. Just update this line in templating.js to iterate over multiple files instead of reading a single file.

Support for locale variants

This may be a little bit more work. We should check that all the dependencies support that. See

  • https://github.com/lovasoa/whitebophir/blob/master/server/templating.js#L34

Make Go translatable

See https://github.com/lovasoa/whitebophir/blob/master/client-data/index.html#L59 It should be translated in all currently supported languages. An alternative is to just remove the value attribute, and the browser will display a label in the user's language.

lovasoa avatar Jul 07 '20 08:07 lovasoa

Transvision, a tool provided by the French Mozilla community, lists locales in the Source Locale and Target Locale drop-downs.

ovari avatar Jul 07 '20 09:07 ovari

@ovari : I don't understand. What is your point ?

lovasoa avatar Jul 07 '20 09:07 lovasoa

Thought it might help. Unfortunately it didn't. Please disregard. Thanks

ovari avatar Jul 07 '20 09:07 ovari

I added your point from #103 here. If you want to make pull requests to address one or several of the points above, it will be very appreciated :)

lovasoa avatar Jul 07 '20 10:07 lovasoa