react-contenteditable icon indicating copy to clipboard operation
react-contenteditable copied to clipboard

#84: Addition additional states of contenteditable

Open dinukadesilva opened this issue 6 years ago • 6 comments

This fixes #84

https://w3c.github.io/editing/contentEditable.html#h-contenteditable

dinukadesilva avatar Mar 31 '18 17:03 dinukadesilva

thank you for the PR

lovasoa avatar Mar 31 '18 21:03 lovasoa

but I don't think exposing the state as a list of boolean properties is a good idea

lovasoa avatar Mar 31 '18 21:03 lovasoa

what should the user expect if he sets several boolean state options to true?

lovasoa avatar Mar 31 '18 21:03 lovasoa

It is according to the priority sequence mentioned in https://w3c.github.io/editing/contentEditable.html#h-contenteditable. That's why these have been enclosed in separate if clauses.

dinukadesilva avatar May 17 '18 15:05 dinukadesilva

@lovasoa Any updates regarding this pull request

dinukadesilva avatar Jun 14 '18 03:06 dinukadesilva

any updates on this? can i help with any changes to move this along?

lewisf avatar Nov 13 '19 02:11 lewisf