Ophir LOJKINE
Ophir LOJKINE
In fact Ophir::HEADER should be renamed to Ophir::HEADINGS. My mistake. Footnotes are not the same thing as footers.
We could add support for headers and footers, but we need to think about how to do it, as hearders and footers do not make much sense in HTML.
Yes, it's a very good idea! Breaking things is not that terrible, since we are the only two known users of ophir.php ;)
And I think it would be even more readable and easy to extend if we had something like: ``` PHP $ophir->setConfig(Ophir::FOOTNOTE, Ophir::DISCARD); $ophir->setConfig(Ophir::LINK, Ophir::IMPORT_TEXT); ```
Johannes, I think this is a very clever idea. It would make the code much more readable and structured, and thus easier to maintain. It would also make support for...
Do you think this would fit our needs: http://il1.php.net/manual/en/class.domnode.php ?
Your work is very interesting, and cleans up the code, which is a good thing. However, I'm a bit concerned about the memory impact of such a change. The input...
Reading our previous discussion, I realize that I am the one who proposed to use DOMNodes! But I can't remember why I said it would make it easier to add...
I agree about html errors. But I think the "zip://" thing is handled by the PHP Zip extension, which is not "web-specific". Are there good reasons we should rely on...
See: https://github.com/logstash-plugins/logstash-filter-geoip/blob/a2516756b50aecc59367ab14e32b1f12e0b1f24c/src/main/java/org/logstash/filters/GeoIPFilter.java#L176