Ophir LOJKINE

Results 1257 comments of Ophir LOJKINE

We shouldn't have to take more than an optional oidc discovery url. Keycloak implements the standard oidc protocol; I don't think this should be keycloak-specific, mention a realm, or need...

Yes, we can use an external lib. But we should keep compatibility with the existing jwt authentication mechanism described in https://github.com/lovasoa/whitebophir#authentication

Well, all the user interface code is in the `client-data` folder, you can do whatever you want with it. Remember that WBO is published under the [AGPL](https://github.com/lovasoa/whitebophir/blob/master/LICENSE), so you have...

Hello ! Thank you for the suggestion. In the meantime, all the tools already have keyboard shortcuts. You can switch between *hand* and *pencil* by pressing **h** and **p**.

The size/quality reduction could be done prior to sending on the client side with a canvas, with the server only validating that the document does not exceed the maximum size.

Doesn't the existing hand tool work to move images created with this patch?

I just haven't had the time to work on it yet.

Yes, these are good ideas. But all of them require a significant refactoring of the existing code. There is currently no spacial index of the shapes.

Hello, There is currently no concept of authenticated user in WBO. You can protect the whole application with a password if you want to using a forward proxy such as...

@vinuvvk88 : If you implement it and make a pull request, then yes, it's coming ! 😉