terraform-provider-uptimerobot icon indicating copy to clipboard operation
terraform-provider-uptimerobot copied to clipboard

Published 20 hours ago • verified publisher icon louy

add custom_http_statuses option

Open mtanda opened this issue 5 years ago • 3 comments

Fixes https://github.com/louy/terraform-provider-uptimerobot/issues/69

I'd tried to use TypeMap, but TypeMap doesn't allow to nest TypeList. https://discuss.hashicorp.com/t/resource-schema-typelist-as-element-for-typemap/4809

So, I use TypeSet. I investigate about how to test TypeSet, but I can't find the good method. I didn't add test code...

mtanda avatar Oct 22 '20 10:10 mtanda

Someone to review this PR? I'm interested!

dlecan avatar Dec 18 '20 12:12 dlecan

I thought it was a very good fix, so I created a PR based on it with additional tests at https://github.com/vexxhost/terraform-provider-uptimerobot/pull/21

yktakaha4 avatar Sep 06 '22 12:09 yktakaha4

PR has been merged with this provider. https://github.com/lapras-inc/terraform-provider-uptimerobot

yktakaha4 avatar Oct 27 '22 06:10 yktakaha4