Add http_method parameter for monitors

[glebiller]

Added support for the optional http_method parameter available with Pro plan. Unfortunately this parameter is for the moment only available for newMonitor & editMonitor but not for getMonitors, and as soon as the parameter is set we will loose the idempotency.

I have open a request to UptimeRobot asking to add this http_method parameter also in the getMonitors endpoint, as soon as it's completed this should make the test pass (and possibly also cleaning the if that I had to add)

[glebiller]

I have received the parameter to pass to getMonitors to get the http_method results back from the API. Everything is now working properly :)

[dlecan]

thank you @Kissy, I need this :)

Can this be merged?

[louy]

Sadly I don't have a pro account to test this but would love to merge it. It LGTM so can you just confirm the tests work with your account? @Kissy

[MyBabych]

@Kissy @louy Hi, could you clarify will http_method parameter implemented or not? I really need it for my case.

[glebiller]

Sorry, however the parameter cannot be used until the PR has been merged :)

[dzmitrykliapkou]

@louy @Kissy Hi! Do you have any updates regarding this pull request?

[augustgerro]

Hey @louy @Kissy, we need it :) Please merge the PR

[glebiller]

@louy Sorry for the delay, I just rebased the code so it can be merged again. I checked today with UptimeRobot Pro account and I successfully ran the acceptance test:

~/Workspace/terraform-provider-uptimerobot(http-method ✗) go test ./uptimerobot -v -run TestUptimeRobotDataResourceMonitor_http_method
=== RUN   TestUptimeRobotDataResourceMonitor_http_method
--- PASS: TestUptimeRobotDataResourceMonitor_http_method (2.35s)
PASS
ok      github.com/louy/terraform-provider-uptimerobot/uptimerobot      2.690s

I have been using my version for a long time now and it's working great in real scenario.

[augustgerro]

Hi @louy could you please check the PR 🙏

[vchong]

Hi @louy can this PR be merged please?