csharp-monad icon indicating copy to clipboard operation
csharp-monad copied to clipboard

Make library portable

Open ApocalypticOctopus opened this issue 9 years ago • 4 comments

It would be nice if the NuGet package was a portable class library. This could be done by using the template called Class Library (Portable) in Visual Studio 2015 Community Edition.

The advantage to doing it this way is that your library can be used in applications for Windows Store, Windows Phone, Xamarin Android, Xamarin iOS, Silverlight, etc.

ApocalypticOctopus avatar Jan 12 '16 22:01 ApocalypticOctopus

Want to make a PR for review?

jgrosso avatar Jan 12 '16 22:01 jgrosso

Yes, that would be great!

ApocalypticOctopus avatar Jan 12 '16 22:01 ApocalypticOctopus

We'll be watching... good luck!

jgrosso avatar Jan 12 '16 22:01 jgrosso

Thanks!

Unfortunately the IsAssignableFrom method is not available for .NET 4.5 (or 4.5.1) Portable Class Libraries.

To make CSharpMonad be a portable class library, we'll have to upgrade it to .NET 4.6 and a minimum of Visual Studio 2015. The advantage is that this library will be available for all Windows Universal 10 apps (which includes all the platforms listed here); the disadvantage is that the library wouldn't be available to code using less than .NET 4.6.

What do you think--is this tradeoff acceptable?

ApocalypticOctopus avatar Jan 13 '16 14:01 ApocalypticOctopus