php-ntlm icon indicating copy to clipboard operation
php-ntlm copied to clipboard

$domain used as parameter and local variable

Open PiNotEqual3 opened this issue 11 years ago • 0 comments

Something is wrong here with $domain:

function ntlm_get_challenge_msg($msg, $challenge, $targetname, $domain,
    $computer, $dnsdomain, $dnscomputer)
{
        $domain = ntlm_field_value($msg, 16);

See https://github.com/loune/php-ntlm/blob/master/ntlm.php#L118

It is only used once, so maybe the function parameter is not needed?

PiNotEqual3 avatar Oct 29 '13 12:10 PiNotEqual3