Vicente Mataix Ferrándiz
Vicente Mataix Ferrándiz
Just to mention @pooyan-dadvand, maybe this branch is old, and we can securely remove it: https://github.com/KratosMultiphysics/Kratos/tree/core/move-run-kratos-to-core
Nice contribution, the question is why a rigid solid is on the CoSIM?, it is something generic that may fit in other apps like the structural and even the core
> I wonder if we shouldn't implement the rigid body solver in the KratosCore. IMO this is a key capability that can be used not only in the context of...
> > I wonder if we shouldn't implement the rigid body solver in the KratosCore. IMO this is a key capability that can be used not only in the context...
As this will affect many external CI for some teams (FYI @KratosMultiphysics/altair), I will wait some days to merge
> @loumalouomega or @pooyan-dadvand > > Any idea about this error: > > ``` > /home/roigcarlo/Kratos/kratos/processes/from_json_check_result_process.cpp:584:81: error: no matching function for call to ‘distance(Kratos::Parameters::const_iterator, Kratos::Parameters::const_iterator)’ > 584 | auto size_parameters...
> Meanwhile, to me, the error seems to come from some cross includes I also thought that, I tried different configurations and I didn't get it work...
Are we C++17 already?
> > 1. In order to reduce code repetition in the `thermal_constitutive_laws `I'm going to slightly modify the original CL. This change consists in subtituting the `rValues.GetProperties()[YOUNG_MODULUS]` by a new...
@AlejandroCornejo a minimal C++ test with a minimal hexa could be interesting