louketo-proxy icon indicating copy to clipboard operation
louketo-proxy copied to clipboard

vhost in resources[].uri

Open xeor opened this issue 4 years ago • 2 comments

vhost in resources[].uri

Summary

It would be useful to be able to specify a hostname in the resource-uri field so you could point multiple domains at louketo-proxy.

Why?

It would make configuration like this simpler.

'--resources=uri=/jira*|roles=jira',
'--resources=uri=/grafana*|roles=grafana',

Instead, we could do:

'--resources=uri=jira.*|roles=jira',
'--resources=uri=grafana.*|roles=grafana',

or specify the whole domain.

It's much easier to setup services as separate sub-domains than on dedicated sub-paths. Often, sub-paths need app-configuration and the app needs to support it. Let's encrypt also have support for wildcard domains now, which is going to make this a very attractive setup.

How

It looks like uri are already prefixed with a /, so it doesnt seam to be a feature that needs an api-change. uri can also be domain, so you will get --resources=domain=jira.*

Acceptance criteria

Support for using domains/sub-domains as resources

xeor avatar Jun 25 '20 19:06 xeor

@xeor it seems to me like a duplicate of https://github.com/louketo/louketo-proxy/issues/524. Could you please confirm and close?

abstractj avatar Jun 25 '20 20:06 abstractj

@abstractj this is not a duplicate.. This is about adding domains as a valid resource-url. #524 is about adding different endpoints per resource.

A single upstream can handle multiple hosts now as well by using --preserve-host=true, but you can't use it for anything useful, since you are can't specify which roles should be valid per host (since you can only specify resources based on url-paths).

xeor avatar Jun 25 '20 20:06 xeor