louketo-proxy icon indicating copy to clipboard operation
louketo-proxy copied to clipboard

Added opentracing jaeger middleware

Open sam-burrell opened this issue 5 years ago • 1 comments

Added opentracing jaeger middleware

Summary

Discussion here: https://groups.google.com/forum/#!topic/louketo/Dach4U_Iza8

Proposal Introduce a flag to enable opentracing, under this flag: Write some middleware to add extraction and injection of traces with some basic debug tags Initialise a jaeger client to report spans

Type

[] Bug fix [] Feature request [x] Enhancement [] Docs

Why?

Keycloak itself uses wildfly. Wildfly introduced support for open tracing https://wildfly.org/news/tags/wildfly/page/2/. There is talk of introducing support to Keycloak It would be good see the auth flow through opentracing for debugging.
For us, we would like to integrate the gatekeeper into our auth flow for debugging.

Requirements

Configured using the standard jaeger client env variables

How to try it?

Use jaeger-all-in-one https://www.jaegertracing.io/docs/1.18/getting-started/ to test locally.

Documentation

Can write this as needed.

Additional Information

I can't see a clean way the proxy closes so right now this is not cleanly closing the jaeger client. Is cleanly shutting down also something worth thinking about?

Checklist:

Happy to help with anything the further this.

  • [x] My change requires a change to the documentation or CHANGELOG.
  • [ ] I have updated the documentation/CHANGELOG accordingly.

sam-burrell avatar Jun 11 '20 15:06 sam-burrell

Why does this introduce so many new dependencies? @sam-burrell it's security software, does it need all that?

asomervell avatar Jun 29 '20 06:06 asomervell