stanford-core-nlp icon indicating copy to clipboard operation
stanford-core-nlp copied to clipboard

Published 20 hours ago • verified publisher icon louismullie

Add gemspec requirements attribute

Open guilhermesimoes opened this issue 8 years ago • 4 comments

This information will appear on the gem's page on rubygems.org. http://guides.rubygems.org/specification-reference/#requirements

guilhermesimoes avatar Dec 23 '16 21:12 guilhermesimoes

@guilhermesimoes that's very useful, thank you! But I think, we should elaborate this message a bit. I'll prepare the end version of the README with the installation section, so we could link to it from the post install message.

arbox avatar Dec 24 '16 12:12 arbox

Just want to clarify that post_install_message is one thing, requirements is another. requirements are only visible on rubygems.org. And long requirements messages usually don't look so good. Here are some examples:

guilhermesimoes avatar Dec 24 '16 19:12 guilhermesimoes

@guilhermesimoes sorry, I expressed my thoughts misleading. Since requirements is a free text field we could elaborate the message, and then link to is as well from the post_install_message. We need a string variable for that. The text should contain the minimum version, 3.5.0 is a good default. Thank you for your help and ideas!

arbox avatar Dec 24 '16 20:12 arbox

Aah, that makes sense. Please feel free to edit this PR or close it and create a totally new commit :smile:

guilhermesimoes avatar Dec 25 '16 23:12 guilhermesimoes