uptime-kuma icon indicating copy to clipboard operation
uptime-kuma copied to clipboard

Published 20 hours ago • verified publisher icon louislam

[Monitor Type] Real Browser with Keyword & Iframe Support

Open bthurlow opened this issue 1 year ago • 8 comments

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [x] I have read and understand the pull request rules.

Description

Fixes #4068

Adds a real browser keyword monitoring type that has the ability to examine the content of iframes while looking for the keyword.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I ran ESLint and other linters for modified files
  • [x] I have performed a self-review of my own code and tested it
  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • [x] My changes generates no new warnings
  • [ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image image image

bthurlow avatar Nov 28 '23 22:11 bthurlow

Formatting changes unrelated to a PR makes it impossible to review.

chakflying avatar Dec 01 '23 18:12 chakflying

@chakflying I have reverted some of the formatting that came over to make for an easier review of the changes.

bthurlow avatar Dec 04 '23 15:12 bthurlow

Note that this conflicts with #3919.

chakflying avatar Dec 05 '23 06:12 chakflying

And duplicate code, which make it hard to maintain in the future. If I want to fix bug of this I have to fix it 2 times.

Those new features in real-browser such as remote browser and enlarge image I believe they are not available for this due to duplicate code.

According to our pull request rules, we should have a discussion on how to design it first.

louislam avatar Dec 05 '23 09:12 louislam

Hi @bthurlow, any chance you can get into discussion with Louis ? I would really like to see that feature in Uptime Kuma.

BR and thanks for your efforts Marcus

MarcAroni81 avatar Jan 17 '24 09:01 MarcAroni81

@louislam If it suits you, once I can get back on this code base, I'll see about consolidating all the keyword code into a single method to make management and reuse much better.

cc: @MarcAroni81

bthurlow avatar Jan 24 '24 16:01 bthurlow

Hi, As @MarcAroni81 stated, I would also really like to see that feature in a future version of Uptime Kuma. Thanks for your work and best regards, Seb

deckardstp avatar Mar 01 '24 14:03 deckardstp

Extracting keyword and other checks is tracked in https://github.com/louislam/uptime-kuma/pull/3919 I think closing this PR is better. @chakflying do you agree?

CommanderStorm avatar Mar 01 '24 14:03 CommanderStorm