uptime-kuma icon indicating copy to clipboard operation
uptime-kuma copied to clipboard

Add 'zabbix trigger' monitor

Open Hex4919 opened this issue 1 year ago • 4 comments

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [x] I have read and understand the pull request rules.

Description

I want to add a 'Zabbix Trigger' Monitor, which will query the API of a Zabbix Server and get the status of a trigger.

Resolves #1960

Why? I use uptime-kuma as a simple 'customer-side' status page. In the background there is more complex monitoring using Zabbix.
It would be nice to use the existing data & triggers from zabbix and show them in uptime-kuma, to get the true overview into the status page and not only part of the monitoring.

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I ran ESLint and other linters for modified files
  • [x] I have performed a self-review of my own code and tested it
  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • [x] My changes generates no new warnings
  • [ ] My code needed automated testing. I have added them (this is optional task)

Hex4919 avatar Nov 01 '23 23:11 Hex4919

If I understand it correctly, you meant this monitor will query the Zabbix API in a fixed interval like another monitors do.

If yes, it is OK to be added.

You can add a new monitor type here: https://github.com/louislam/uptime-kuma/tree/master/server/monitor-types

Here is the tailscale monitor for your reference: https://github.com/louislam/uptime-kuma/pull/3178

I am still working on 2.0.0, this pr may be expected in 2.2.0.

louislam avatar Nov 24 '23 07:11 louislam

Let me know if assistance is needed, this would be incredible for me as I use Zabbix for our admins, and uptime kuma for our customers status pages.

DonovanDiamond avatar Nov 27 '23 11:11 DonovanDiamond

Hi, thanks for your Feedback. I already started trying out a implementation, so it shouldn't take long to finish it.

If I understand it correctly, you meant this monitor will query the Zabbix API in a fixed interval like another monitors do.

Exactly.

Hex4919 avatar Nov 27 '23 16:11 Hex4919

Please add translation for en.json only. Other languages should be added through Weblate.

chakflying avatar Dec 01 '23 18:12 chakflying