uptime-kuma icon indicating copy to clipboard operation
uptime-kuma copied to clipboard

Published 20 hours ago • verified publisher icon louislam

Add xml support to HTTP monitors

Open bayramberkay opened this issue 1 year ago • 4 comments

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [x] I have read and understand the pull request rules.

Description

There is an existing pr request but I guess it hasn't been active for a long time. That's why I just wanted to make a pr request by copy-pasting the xml part. I think it will help most people waiting for this feature.

Fixes

  • https://github.com/louislam/uptime-kuma/issues/1679
  • https://github.com/louislam/uptime-kuma/issues/1332
  • https://github.com/louislam/uptime-kuma/pull/1987

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I ran ESLint and other linters for modified files
  • [x] I have performed a self-review of my own code and tested it
  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • [x] My changes generate no new warnings
  • [ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

xml-support-to-http-monitors

bayramberkay avatar Dec 28 '22 19:12 bayramberkay

It's a really simple pull request. I am waiting for your support. @louislam

bayramberkay avatar Dec 28 '22 19:12 bayramberkay

pr request by copy-pasting the xml part

I haven't compared the code yet, you mean you copy the code from #1987? I think we should ask if @JustinTisdale agree this first, as @JustinTisdale cannot be a contributor displayed on GitHub and the Git history in this way.

Alternatively, you can keep @JustinTisdale's commit by forking his repo and modify it.

louislam avatar Jan 05 '23 11:01 louislam

Hi @louislam,

I guess @JustinTisdale hasn't been active for a while. Justin added for both XML and x-www-form-urlencoded. I just took the XML one and did some refactoring. I haven't done x-www-form-urlencoded's test, so I found it inconvenient.

I tried to reach @JustinTisdale on social media (linkedin instagram) but could not reach him.

bayramberkay avatar Jan 05 '23 12:01 bayramberkay

It is awesome. We are waiting for it. Look forward to using. @louislam

Genc avatar Jan 09 '23 09:01 Genc

I tried to reach @JustinTisdale on social media (linkedin instagram) but could not reach him.

Then maybe you have to take the second path. Fork his branch, copy/commit your modified files to that branch and force push to this pr.

louislam avatar Jan 14 '23 11:01 louislam

I tried to reach @JustinTisdale on social media (linkedin instagram) but could not reach him.

Then maybe you have to take the second path. Fork his branch, copy/commit your modified files to that branch and force push to this pr.

Mission complete . Can you check this pr: https://github.com/louislam/uptime-kuma/pull/2610

bayramberkay avatar Jan 14 '23 14:01 bayramberkay