uptime-kuma icon indicating copy to clipboard operation
uptime-kuma copied to clipboard

Bug fix: gRPC check throws errors when response data size > 50 chars

Open minhhoangvn opened this issue 2 years ago • 1 comments

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [x] I have read and understand the pull request rules.

Description

Fixes #2480

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I ran ESLint and other linters for modified files
  • [x] I have performed a self-review of my own code and tested it
  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • [x] My changes generate no new warnings
  • [ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

minhhoangvn avatar Dec 28 '22 15:12 minhhoangvn

😅 @louislam and @Saibamen could you please take another look at this PR

minhhoangvn avatar Dec 28 '22 15:12 minhhoangvn