uptime-kuma icon indicating copy to clipboard operation
uptime-kuma copied to clipboard

Fix spelling in README

Open SirMorfield opened this issue 2 years ago • 4 comments

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [x] I have read and understand the pull request rules.

Description

Fix some spelling in the README Add docker-compose to the README

Type of change

  • Translation update
  • Other

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I ran ESLint and other linters for modified files
  • [x] I have performed a self-review of my own code and tested it
  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • [x] My changes generate no new warnings
  • [x] My code needed automated testing. I have added them (this is optional task)

SirMorfield avatar Dec 06 '22 17:12 SirMorfield

No plan to add this in README.md. And it is already available in:

  • https://github.com/louislam/uptime-kuma/blob/master/docker/docker-compose.yml
  • https://github.com/louislam/uptime-kuma/wiki/%F0%9F%94%A7-How-to-Install

louislam avatar Dec 11 '22 10:12 louislam

I removed the docker compose part. But can we still merge the spelling fix part of this PR?

SirMorfield avatar Dec 15 '22 22:12 SirMorfield

@louislam See above comment

SirMorfield avatar Dec 23 '22 11:12 SirMorfield

Please rename PR title

Saibamen avatar Jan 02 '23 09:01 Saibamen