uptime-kuma icon indicating copy to clipboard operation
uptime-kuma copied to clipboard

Published 20 hours ago • verified publisher icon louislam

Add xml and x-www-form-urlencoded support to HTTP monitors

Open JustinTisdale opened this issue 1 year ago • 5 comments

Description

Fixes #1679 and #1332

DRAFT: I will resolve the remaining TODO comments. I've tested (to the limit of my ability) that this doesn't break existing monitors created in previous versions. I've tested json and xml body encoding. x-www-form-urlencoded needs more testing.

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I ran ESLint and other linters for modified files
  • [x] I have performed a self-review of my own code and tested it
  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • [x] My changes generate no new warnings
  • [ ] My code needed automated testing. I have added them (this is optional task)

Screenshots

image

JustinTisdale avatar Aug 12 '22 01:08 JustinTisdale

@louislam Just wanted to check if this feature is something you want to merge. If so I'll do some more testing/bugfixing on the branch and move the PR out of draft mode.

JustinTisdale avatar Aug 17 '22 14:08 JustinTisdale

When can this merge? I need this feature

mitchross avatar Sep 15 '22 17:09 mitchross

That feature would be great :+1:

mweibel avatar Sep 23 '22 09:09 mweibel

@louislam Just wanted to check if this feature is something you want to merge. If so I'll do some more testing/bugfixing on the branch and move the PR out of draft mode.

Yes, it is a great feature.

louislam avatar Oct 03 '22 08:10 louislam

It's awesome . It's a very good idea and i really need it. When do we release this? @JustinTisdale @louislam

Genc avatar Dec 21 '22 17:12 Genc

Necessary thing! Any plans for a release?

Zaktus avatar Apr 04 '23 18:04 Zaktus

I'm just testing out Uptime Kuma - awesome tool! But if this is ready for release, it would be really nice to have :)

anderskvist avatar Jul 21 '23 20:07 anderskvist

Any plans for a release?

See https://github.com/louislam/uptime-kuma/pull/2610#issuecomment-1481221254 ⇒ The reason this was never released is that this feature was never finished

⇒ You could provide a PR by adding another encoding, like in https://github.com/louislam/uptime-kuma/pull/2610

CommanderStorm avatar Jul 21 '23 21:07 CommanderStorm

PR for adding x-www-form-urlencoded support https://github.com/louislam/uptime-kuma/pull/3499 :D

anderskvist avatar Jul 29 '23 21:07 anderskvist