uptime-kuma
uptime-kuma copied to clipboard
louislam
Disable scroll wheel value change on panel
⚠️ Please verify that this feature request has NOT been suggested before.
- [X] I checked and didn't find similar feature request
🏷️ Feature Request Type
UI Feature
🔖 Feature description
This should be super simple to implement, test, deploy.
When you ADD:
- You can edit Port number with scroll.
When you EDIT:
- You can change both Port, and Heartbeat values with scroll wheel.
✔️ Solution
Disable this behavior. While moving around with the mouse, it's extremely simple to change these values.
According to this, you can use "tel" instead of "number" input type: https://stackoverflow.com/questions/9712295/disable-scrolling-on-input-type-number
I checked it, worked for me (disabled scroll) but of course, more testing is needed I believe.
❓ Alternatives
No response
📝 Additional Context
No response
Why is not allowing users to use the scroll wheel on these inputs important/better?
Because when you scroll through the settings, you can accidentally change the port number or other number resulting in a headache. That's about it.
There appears to be some literature out there supporting the use of <input type="text" inputmode="numeric" pattern="[0-9]*"> for integers
- https://stackoverflow.blog/2022/12/26/why-the-number-input-is-the-worst-input/
- https://technology.blog.gov.uk/2020/02/24/why-the-gov-uk-design-system-team-changed-the-input-type-for-numbers/
Idk if this is a fix worth implementing.
I am going to leave this open for post-v2.0 discussion
On the other hand, the ability to quickly increment/decrement the value does provide convenience for e.g. increasing the number of retries by 1 easily.
We don't really have the user research to say which method is generally better for people.
Yeah up to you guys. I just often go through monitors to double-check and it's very easy to mess something up due to this. I remember Qt also had fields like this and qBittorrent would change values as I scrolled settings.
I don't know, you guys know best. Thanks for your hard work btw!