dockge icon indicating copy to clipboard operation
dockge copied to clipboard

feat: dockge set/update agent friendly name

Open lohrbini opened this issue 1 year ago • 14 comments

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • [x] I have read and understand the pull request rules.

Disclaimer

I am not a Software programmer and only have basic understandings on any Programming Languages used in the project, so please be patient and maybe assist me with further development of this feature

Description

Since dockge agents is still a beta feature and in the future maybe more and more remote instances will be added I wanted to enable the option for setting a friendly name for a remote instance. If the name is not set via the prompt. The default agent.url will be displayed Fixes #345

Type of change

  • New feature (non-breaking change which adds functionality)

  • [x] My code follows the style guidelines of this project

  • [x] I ran ESLint and other linters for modified files

  • [x] I have performed a self-review of my own code and tested it

  • [x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)

  • [x] My changes generate no new warnings

  • [ ] My code needed automated testing. I have added them (this is optional task)

Screenshots

dgagents-friendlyname

lohrbini avatar Feb 01 '24 07:02 lohrbini

After testing your PR, I have two small remarks:

  1. Could you add the translation key "Friendly Name" to the en.json file?
  2. It would be interesting for the friendly name to be applied here as well si7sb7 hhi5hq

cyril59310 avatar Feb 01 '24 18:02 cyril59310

Hey @cyril59310,

thanks for your feedback.

The translation can be added - for sure. ~~Could you maybe point out, where the friendlyName is missing exactly ?~~ Figured out where you want to add the friendlyName

Currently trying to refactor the code a bit to enable renaming - which seems more difficult as expected ..

lohrbini avatar Feb 01 '24 18:02 lohrbini

In the file

frontend/src/lang/en.json ,

please add "Friendly Name": "Friendly Name" so that translators can translate it into other languages using our Weblate tool.

cyril59310 avatar Feb 01 '24 18:02 cyril59310

@cyril59310 point 2 of your request is now also done. Only need to update codebase and remove all debug options

image

lohrbini avatar Feb 01 '24 21:02 lohrbini

Thank you for taking my feedback. I noticed afterwards that here too, the friendly name could be added. image

cyril59310 avatar Feb 02 '24 17:02 cyril59310

Thanks again @cyril59310 . This is now also implemented

lohrbini avatar Feb 03 '24 15:02 lohrbini

Finally I was able to get the update feature working. Friendly names are now updated properly by a small dialog

image image

@larswmh maybe need help this time with syntaxing/linting issues for sqlite statement. Or even a better solution than a "hardcoded" query

lohrbini avatar Feb 06 '24 07:02 lohrbini

I made some suggestions in order to add translation keys for our translators.

cyril59310 avatar Feb 06 '24 17:02 cyril59310

Long time no see. Will have a look the next days on all your feedback. Many thanks 🙏🏻

lohrbini avatar May 22 '24 19:05 lohrbini

would love for this to be added!

mon5termatt avatar Jun 21 '24 05:06 mon5termatt

Ready & happy about a second review :)

&& could need help with that one failing CI pipeline

lohrbini avatar Aug 06 '24 16:08 lohrbini

on which tag do i need to be to have this feature?

XenoUniv3rse avatar Aug 17 '24 12:08 XenoUniv3rse

on which tag do i need to be to have this feature?

It is planned to be included in the next release v1.5.0 . To use this feature you need to be on my branch and build the image on your own

lohrbini avatar Aug 17 '24 13:08 lohrbini