node-redis-pubsub icon indicating copy to clipboard operation
node-redis-pubsub copied to clipboard

Published 20 hours ago • verified publisher icon louischatriot

Refactor part 1: Use ES6

Open notVitaliy opened this issue 7 years ago • 7 comments

notVitaliy avatar Dec 10 '17 17:12 notVitaliy

This is a pretty huge rewrite. Any particular reason that this needs to be done?

RangerMauve avatar Dec 11 '17 15:12 RangerMauve

I'm planning a part 2 of this, to use async/await

This PR starts that process.

notVitaliy avatar Dec 13 '17 04:12 notVitaliy

I like the idea, but I'm worried about supporting older Node environments. What do you think about using babel transpilation to es5 so that the library can still be used on older version?

RangerMauve avatar Dec 13 '17 14:12 RangerMauve

Yea, that'll work. It could be done as a pre-publish hook for npm.

notVitaliy avatar Dec 13 '17 20:12 notVitaliy

Would you mind setting that up before we merge it in? Also, would you be interested in becoming a collaborator?

RangerMauve avatar Dec 13 '17 20:12 RangerMauve

Sure, I'll try to get to it in the next couple weeks.

Yea, why not. I've got some ideas for this lib.

  • an option for message reply
  • push/worker mode (message is only ever sent to 1 worker, worker needs to ack)

Pretty sure both of those can be done with bacon.js or RxJS.

notVitaliy avatar Dec 14 '17 00:12 notVitaliy

@louischatriot Would you mind giving @notVitaliy access as a collaborator?

RangerMauve avatar Dec 14 '17 14:12 RangerMauve