arnis icon indicating copy to clipboard operation
arnis copied to clipboard

Upload artifact after pushing to main

Open sebastiaanspeck opened this issue 11 months ago • 5 comments

Could be used like a pre-release or for ease to not need to rebuild locally after a fix has been pushed to main

sebastiaanspeck avatar Jan 03 '25 03:01 sebastiaanspeck

Sounds like a good idea, however according to the ci-build.yml logic, will this also upload a new artifact each time a pull request CI starts running? :D https://github.com/louis-e/arnis/blob/7d0d186f3d67844f2f5109837ed9e6ab81427ddc/.github/workflows/ci-build.yml#L5

louis-e avatar Jan 03 '25 15:01 louis-e

Sounds like a good idea, however according to the ci-build.yml logic, will this also upload a new artifact each time a pull request CI starts running? :D https://github.com/louis-e/arnis/blob/7d0d186f3d67844f2f5109837ed9e6ab81427ddc/.github/workflows/ci-build.yml#L5

That's true.. we can add an if-statement I believe to check for the GH Action trigger

sebastiaanspeck avatar Jan 03 '25 16:01 sebastiaanspeck

pls @louis-e

sh2kcs avatar Jan 23 '25 04:01 sh2kcs

This should be revived and merged into main. Looks like a good feature, since the main branch is getting a lot useful features and bugfixes, but many users aren't able to build the program from source and also it's too long to wait for a new release

Oleg4260 avatar Apr 30 '25 17:04 Oleg4260

This should be revived and merged into main. Looks like a good feature, since the main branch is getting a lot useful features and bugfixes, but many users aren't able to build the program from source and also it's too long to wait for a new release

I have just merged main into this branch again. Haven’t tested if all targets are uploaded now. Feel free to check and add suggestions.

sebastiaanspeck avatar Apr 30 '25 23:04 sebastiaanspeck