lottie-react-native icon indicating copy to clipboard operation
lottie-react-native copied to clipboard

fix: DirectEvent to BubblingEvent on Android/Windows

Open Sunbreak opened this issue 1 year ago • 5 comments

fix #1221

Sunbreak avatar Apr 22 '24 16:04 Sunbreak

Hey @Sunbreak. Sorry we haven't reviewed your PR. I will allocate some free time this weekend, make sure the Android setup is working good for new arch and old arch and either give feedback or approve and merge it.

TheRogue76 avatar Apr 29 '24 22:04 TheRogue76

@Sunbreak Checked on Android in Fabric, the events do not seem to be sent anymore: Screenshot 2024-05-04 at 09 42 23

TheRogue76 avatar May 04 '24 07:05 TheRogue76

Or BubblingEvent to DirectEvent on iOS?

Sunbreak avatar May 06 '24 09:05 Sunbreak

Or BubblingEvent to DirectEvent on iOS?

Come to think of it, maybe it should all be direct events, even for iOS and in the spec. The point of Bubbling event was that we had some weird setup where the custom view of Lottie was wrapped by another view, but now that it is gone, maybe the spec should change and it should all become direct event, cause we are capturing it there directly. Try it out, let me know how it works.

TheRogue76 avatar May 06 '24 10:05 TheRogue76

Any updates @Sunbreak ?

TheRogue76 avatar Jun 20 '24 05:06 TheRogue76