lost icon indicating copy to clipboard operation
lost copied to clipboard

fix (#265): set elapsed realtime when mocking a trace for SDK>JELLY_BEAN_MR1

Open skypal opened this issue 6 years ago • 2 comments

Overview

On devices with SDK >= JELLY_BEAN_MR1, tracing a GPX file won't work anymore, because the changes from #244 introduced the usage of the real time clock in nanoseconds, but forgot to have mocked locations also set the corresponding field. I reported this as issue #265

Proposed Changes

Added code that sets elapsed realtime nanos if SDK >= JELLY_BEAN_MR1

skypal avatar Jan 18 '19 16:01 skypal

Hey @skypal thanks for the pull request.

It looks like tests are no longer running on Circle CI since support has been dropped for v1.0. I would want to get this sorted out before we merge any new code.

Are you able to run tests locally? Admittedly, it's been a while since I have actively worked on this project. When I try to running ./gradlew -PdisablePreDex locally in a fresh clone I get the following error:

java.lang.NoClassDefFoundError: Could not initialize class android.content.res.Configuration
	at org.robolectric.shadows.ShadowResources.getSystem(ShadowResources.java:88)
	at android.content.res.Resources.getSystem(Resources.java)

ecgreb avatar Jan 22 '19 22:01 ecgreb

Hi @ecgreb, I must admit, I haven't tried running any tests. I checked my changes by putting all the sources in my project temporarily. I have the current Android Studio installed, which complained about the old Gradle plugin version. I don't feel like the right person to update to the current toolset and the other day I didn't have enough time to restore the old toolchain. What would be the best way to go on now? You updating to the current toolchain? Me, restoring the old toolchain?

skypal avatar Jan 22 '19 22:01 skypal

Closing as this repo is no longer maintained.

msmollin avatar Apr 23 '23 14:04 msmollin