Status bar icon toggle

[tomglynch]

Hi @lostintangent, hope you're doing well. GitDoc is a great tool, but I wanted a feature to have it always show the status bar icon rather than it disappearing when disabled (#89 ). In fixing that, I also ended up fixing #90 as it affected the icons being shown. I handled icons for matching the File Patterns too. Have a look and let me know what you think?

Cheers,

Tom

[tomglynch]

@lostintangent just a follow up comment to see if you have any interest in merging these changes? Cheers

[awalland]

i would also love seeing this merged, since i have the same problem described in #90

[tomglynch]

@lostintangent if no response soon I think I'll pop the fork up on the vs code extension store.

[lostintangent]

@tomglynch hey apologies! I'll review this tomorrow and we can get it merged this week

[tomglynch]

Thanks for all your comments @lostintangent! I agree with everything and have applied them to my latest commit.

1. Added the gitdoc.alwaysShowStatusBarIcon setting (defaulting to false) as you suggested
2. Moved the matches function to watcher.ts and made it exported for reuse
3. Simplified the initialization code to use config.enabled directly
4. Removed redundant context updates since checkEnabled handles this
5. Removed the debounced handler as you suggested it was unnecessary
6. Consolidated status bar updates into the checkEnabled function

The changes maintain backward compatibility while allowing users to opt into the new behavior. Let me know if you'd like me to make any additional adjustments.

I also added a few tests that I haven't pushed yet if you'd like to take a look - but perhaps that's a seperate PR.

[lgruen]

@lostintangent Thanks for your work on this! Any chance to get this PR merged? I think a couple of people are affected by #90.

[M-Kepler]

I'm having the same issue

[tomglynch]

@lostintangent

[ascholerChemeketa]

Would love to see this merged. Currently resorting to a fork to use this in courses to avoid https://github.com/lostintangent/gitdoc/issues/90.

[owenarden]

I am also affected by this. +1 for merging :)