gistpad icon indicating copy to clipboard operation
gistpad copied to clipboard

Remove redundant item from gist menu

Open Ilanaya opened this issue 2 years ago • 3 comments

Ilanaya avatar Apr 13 '22 17:04 Ilanaya

Hey! I'm not sure I'm following the intent of this PR. The code you're removing is necessary to open an arbitrary gist by ID. So if we wanted to prevent from adding an extra list item, for a gist that is already in the list, then we may want to check to see if the user is typing a gist ID vs. a description?

lostintangent avatar Apr 14 '22 15:04 lostintangent

@lostintangen I was also following this, so I think I can answer your questions. Extension were putting that item on the first place that was equal to the value itself without describing the purpose of that. This was done on any arbitrary value and it was kinda annoying. I personally propose the following:

  1. AFAIK gist ID has 32 char length, we can check by that. Also I see you support opening gist by a full URL, so we can also check the value against regexp like /^(https?://)?gist.github.com\//
  2. It would be awesome to add a description to this item like gist ID or URL or something like this

What do you think of it?

zardoy avatar Apr 15 '22 20:04 zardoy

@lostintangent Am I free to implement that?

Ilanaya avatar Apr 25 '22 09:04 Ilanaya

@lostintangent was this fixed in the first place?

zardoy avatar Dec 10 '23 02:12 zardoy