gistpad icon indicating copy to clipboard operation
gistpad copied to clipboard

gistfs crashes SSH remote connection if certain UTF-8 character gets appended to text that contains a URL.

Open tigerinus opened this issue 3 years ago • 0 comments

See microsoft/vscode#143645 for issue details and repro steps.

demo

I first thought it has to do with Remote SSH extension itself, since it reproduces with all extension disabled.

But then if I look closely to the log, I read:

[2022-02-15 22:39:09.485] [exthost] [error] TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
	at c.provideDocumentLinks (c:\Users\xiaoh\.vscode\extensions\vsls-contrib.gistfs-0.3.0\dist\extension.js:51:187466)
	at ee.provideLinks (c:\Users\xiaoh\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:93:111117)

It looks like even when all extensions are disabled, vsls-contrib.gistfs-0.3.0 is still loaded for some reason. So the bug might not have to do with SSH remote extension.

I tried pasting a slight different text (without the Chinese character at the end), it doesn't crash at all.

tigerinus avatar Feb 16 '22 04:02 tigerinus