gistpad icon indicating copy to clipboard operation
gistpad copied to clipboard
verified publisher icon lostintangent

Extra revisions with no changes

Open celynw opened this issue 5 years ago • 1 comments

Describe the bug Saving a file with no changes still makes a commit with no changes.

To Reproduce

  1. Have a gist note.
  2. Add some text then remove it again
  3. Save the note

Expected behavior As there were no changes, don't commit and push another revision.

Screenshots This is how it looks in GitHub proper. image

Desktop (please complete the following information):

  • VS Code Version: 1.51.1
  • GistPad Version 0.1.9

Additional context Maybe the ability to disable this this is a feature request? Seems unlikely anybody would want this behaviour though.

celynw avatar Nov 18 '20 17:11 celynw

Thanks for reporting this! I'm surprised to hear this could happen 🤔 VS Code tracks changes between saves, which should prevent the gist file from being in a "dirty" state after your repro steps.

I agree this behavior doesn't make sense. And so instead of adding a setting, I'll look and see how to prevent saving unchanged files 👍

lostintangent avatar Nov 22 '20 05:11 lostintangent

I'm going close this as resolved since I think it's a behavior in VS Code that I can't control. And I haven't received any other reports of it causing an issue for users. That said, please let me know if this is still an issue and I can try to take a look at it again. Thanks!

lostintangent avatar Dec 10 '23 01:12 lostintangent