gistpad icon indicating copy to clipboard operation
gistpad copied to clipboard

version 0.1.8 will suppress string autocompletion in Markdown

Open tangentyh opened this issue 5 years ago • 6 comments

Describe the bug When this extension GistPad of version 0.1.8 and/or the extension :emojisense: of a recent version is enabled, string autocompletion in Markdown will be suppressed.

To Reproduce Steps to reproduce the behavior:

  1. Make sure GistPad of version 0.1.8 and :emojisense: of any version disabled or uninstalled
  2. Enable autocompletion in Markdown with below settings
    {
        "editor.quickSuggestions": {
            "comments": true,
            "other": true,
            "strings": true
        },
        "[markdown]": {
            "editor.quickSuggestions": true
        },
    }
    
  3. Open any Markdown file, and the autocompletion works as the first screenshot shows, where GistPad is of version 0.1.7
  4. Install or enable GistPad of version 0.1.8. Alternatively, install or enable :emojisense:
  5. The autocompletion is now suppressed and broken, like in the second gif screenshot. You can see the string completion is suppressed almost immediately

Expected behavior Autocompletion should remain intact and completions should not be suppressed.

Screenshots image Jul-19-2020 17-39-14

Desktop (please complete the following information):

  • VS Code Version v1.47.2
  • GistPad Version v0.1.8

Additional context

  1. I rely on autocompletion heavily when writing Markdown
  2. Since :emojisense: is shipped along with this extension and can also be the culprit, it is mentioned too
  3. Annoyingly, the extension "GitHub Pull Requests and Issues" can also be the culprit under some circumstances.

tangentyh avatar Jul 19 '20 10:07 tangentyh

@tangentyh Hmm, I’m sorry you ran into this! Just to confirm: does this issue only occur if emojisense is enabled? If so, then it sounds like I should like I should remove that dependency.

lostintangent avatar Jul 20 '20 02:07 lostintangent

@lostintangent both actually. This problem occurs if any of the below:

  • GistPad v0.1.8 is enabled (v0.1.7 is fine) or
  • emojisense is enabled or
  • both emojisense and GistPad v0.1.8 are enabled

tangentyh avatar Jul 20 '20 02:07 tangentyh

I am seeing the same, but emojisense on its own is fine. It only breaks when GistPad is enabled.

Before I dive into the code, is there a place you would suggest looking to debug?

Edit: After a quick glance, perhaps completionProvider is conflicting with vscode-markdown-notes (which Foam is using)?

bs avatar Sep 27 '20 08:09 bs

I'm seeing the same thin across vscode-markdown-notes and gistpad (no emojisense installed) as of 11/15/2020.

da5is avatar Nov 15 '20 18:11 da5is

@da5is Out of curiosity: do you see this behavior if you disable GistPad, but enable vscode-markdown-notes? I’m just curious if it’s a GistPad issue, or maybe an issue with VS Code and extensions that contribute Markdown completion support.

lostintangent avatar Nov 15 '20 18:11 lostintangent

I don't see the issue if GistPad is disabled but vscode-markdown-notes is enabled - just when GistPad is enabled. Odd.

da5is avatar Nov 21 '20 14:11 da5is

Closing this since I haven't seen any reports of the issue in a while, and I'm not sure it still repros. Please feel free to re-open it if you're still encountering this problem

lostintangent avatar Nov 19 '23 19:11 lostintangent