Rob Emanuele
Rob Emanuele
> @lossyrob can you take a look at my recent changes, in particular [8118f10](https://github.com/stac-utils/stac-fastapi/pull/625/commits/8118f10be27f04d5ce2143b5fa9dbbd1b4fd92c3). > > * In `types.config` I added a parameter `validate_response` that defaults to `False` (same as...
It's a similar pattern. I think we could get away with a callable here, and then have auth implementation define a class that serves as a provider, either giving by...
I actually didn't catch `request_modifier`, which can be used for this purpose. E.g.: ```python from requests import Request def req_modifier(req: Request) -> Request: req.headers["Authorization"] = f"Bearer {tp.get_token().token}" return req client...
`Relation.item` is used in other contexts (links to individual items in a catalog/collection), so really we should also add `items`
> One downside to this is that the tests need the pytest parameterized decorator to run, and this doesn't work in the class-based test modules that unittest requires. I ran...
PySTAC tries to maintain the correct path to the asset file if a self contained STAC is copied. So if an item is moved to a new HREF, it will...
Do we know how mypy, pylance etc feels about the return types in downstream contexts? E.g., if the method returns "geopandas.GeoDataFrame", and the types of pystac are published and consumed...
Historically, PySTAC has been very much in the design camp of "do the most simple, scoped thing possible, and carry no dependencies". I think this has served the library well....
I've used the technique described in the first stack overflow link with success, [example](https://github.com/microsoft/planetary-computer-tasks/blob/main/pctasks/core/pctasks/core/tables/base.py#L84)
I'm not sure it's worth it to remove this inheritance from the implementation. Considering they can both be roots, they operate in mostly the same way, the inheritance relationship is...