Cog icon indicating copy to clipboard operation
Cog copied to clipboard

Opus format files no longer show tags when using CoreAudioDecoder

Open faxx1080 opened this issue 1 year ago • 1 comments

Describe I noticed file tags (Artist, album, etc) don't show up with opus files anymore. I tracked this down to PluginController.m:audioDecoderForSource and metadataForURL.

This code restores old behavior:

          if(  ([[_decoders objectAtIndex:i] isEqualToString:@"CoreAudioDecoder"])
             && ( [ext isEqual:@"opus"] || [ext isEqual:@"OPUS"] )   ) {
            DLog(@"PATCH: Removing CoreAudioDecoder for opus - this is for playing not metadata");
            [_decoders removeObjectAtIndex:i];

To Reproduce (delete if not applicable) Steps to reproduce the behavior:

  1. Add an opus file
  2. Tags don't show up.

Expected behavior Tags should show up.

Version information:*

  • macOS version: 15.0.1
  • Cog version: Version 2859 (2859-g8498bba88)

Additional context I believe a recent macOS update (14.6) may have added CoreAudioDecoder for opus files, causing this to happen.

faxx1080 avatar Oct 08 '24 03:10 faxx1080

Feel free to adjust this to a lower priority instead:

https://github.com/losnoco/Cog/blob/main/Plugins/CoreAudio/CoreAudioDecoder.m#L378

kode54 avatar Oct 08 '24 11:10 kode54

This should no longer be an issue.

kode54 avatar Jun 12 '25 09:06 kode54